Add an alternative way to number the USB endpoints #2189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Oct 3, 2019
dhalbert
requested changes
Oct 3, 2019
|
Thank you for your feedback! I have added changes according to your suggestions. |
Two options available: - relative numbering (USB_RELATIVE_EP_NUM = 1) - default - absolute numbering (USB_RELATIVE_EP_NUM = 0) - new!
kamtom480
force-pushed
the
circuitpython-number-endpoint
branch
from
1dc00f9 to
1205d3e
Compare
|
@dhalbert please re-review and merge if it looks ok. Thanks! |
dhalbert
requested changes
Oct 7, 2019
tools/gen_usb_descriptor.py
Outdated
Comment on lines
69
to
84
| if 'CDC' in args.devices: | ||
| if (args.cdc_ep_num_notification == 0 or args.cdc_ep_num_data_out == 0 or | ||
| args.cdc_ep_num_data_in == 0): | ||
| raise ValueError("Endpoint address must not be 0") | ||
|
|
||
| if 'MSC' in args.devices: | ||
| if args.msc_ep_num_out == 0 or args.msc_ep_num_in == 0: | ||
| raise ValueError("Endpoint address must not be 0") | ||
|
|
||
| if 'HID' in args.devices: | ||
| if args.args.hid_ep_num_out == 0 or args.hid_ep_num_in == 0: | ||
| raise ValueError("Endpoint address must not be 0") | ||
|
|
||
| if 'AUDIO' in args.devices: | ||
| if args.midi_ep_num_out == 0 or args.midi_ep_num_in == 0: | ||
| raise ValueError("Endpoint address must not be 0") |
There was a problem hiding this comment.
Could you add the specific endpoint names here? We don't need to save space. E.g. "CDC Endpoint address must not be 0".
tools/gen_usb_descriptor.py
Outdated
| parser.add_argument('--msc_num_endpoint_pairs', type=int, default=1, | ||
| help='Use 1 or 2 endpoint pairs for MSC (1 bidirectional, or 1 input + 1 output (required by SAMD21))') | ||
| parser.add_argument('--renumber_endpoints', type=int, default=1, | ||
| help='use relative(1) or absolute(0) endpoint number') |
There was a problem hiding this comment.
Not too important, but a nice style for boolean argparse arguments is given here: https://stackoverflow.com/a/15008806/142996
|
The way to disable and enable endpoint renumbering has been changed. Now instead of using '--renumber-endpoint 1' or '--renumber-endpoint 0' we can use the '--no-renumber_endpoint' argument to disable renumbering. By default, endpoints are renumbered without providing this argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two options available:
It needs: adafruit/usb_descriptor#8