Sort some modules into ALWAYS-BUILD in mpconfig #2197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Oct 4, 2019
|
@tannewt I revised my test which was missing several module dependancies. USB HID and MIDI are out, but Storage and Random only rely on stub-level implementations of Microcontroller and OS (they use functions that use only CMSIS or don't suffer from being empty/returning 0). Should we consider these stubs a part of the "base build" of Circuitpython? Or should I exclude them? |
tannewt
approved these changes
Oct 5, 2019
|
Merge if it's ready. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following modules have no unique HAL component capable of disrupting the build process of a very early stage port.
Thus, there is never any reason to not include them, even when the MINIMAL_BUILD flag is set. This PR adds an ALWAYS_BUILD flag, which is set unless instructed otherwise, to identify these modules.
Resolves #2191