Add Spresense board #2207
Add Spresense board #2207
Conversation
There was a problem hiding this comment.
Overall it looks really good. I have a few questions inline.
I'd also suggest adding board folders even though only one board is currently supported. It'll make it feel like the others. It'll also work with our tools which also need to be update to auto-build this version. I believe the two spots are https://github.com/kamtom480/micropython/blob/circuitpython-spresense/tools/build_board_info.py#L15 and https://github.com/kamtom480/micropython/blob/circuitpython-spresense/.github/workflows/build.yml#L75.
Thanks!
| // e.g.) | ||
| // - Reference Voltage of A4 and A5 pins on Main Board is 0.7V. | ||
| // - Reference Voltage of A0 ~ A5 pins on External Interface board | ||
| // is selected 3.3V or 5.0V by a IO Volt jumper pin. |
There was a problem hiding this comment.
I wonder if it'd be better to return None to imply that it's unknown. Some boards could also define it per board.
There was a problem hiding this comment.
I didn't change it. This function returns a float variable. Do you want me to change the CircuitPython source code to interpret 0.0 here as None?
There was a problem hiding this comment.
Ya, I think changing shared-bindings to interpret 0.0 as None makes sense. That way an exception will be thrown if the user code uses it in any calculations.
|
Some changes. I added Spresense to your tools, but I'm not sure if it's correct. I'm also not sure what to do with Reference Voltage. |
|
Workflow looks good and I successfully got a REPL on my board! This is ready after tweaking the analog reference voltage. |
|
@tannewt I have added requested changes. |
Add support for Spresense. It is a compact development board based on Sony’s power-efficient multicore microcontroller CXD5602. This port uses the built and exported NuttX SDK.
Supported features:
Unsupported features:
Refer to developer.sony.com/develop/spresense/ for further information about this board.