-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove non-CircuitPython ports #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
412ff58
to
e89bcce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Needs one merge before merge.
I believe there are submodules that are used only by the ports being removed so they could be removed too, for example "lib/stm32lib" and "lib/berkeley-db-1.xx". |
Does this also mean some of the old code only used by those ports will be removed too, like the machine modules? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Feel free to merge after GitHub CI is happy.
@arturo182 |
Sounds good to me. Nice to see CP dropping dead and unsupported code :) |
@tannewt, OK, finally built correctly again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
Remove non-CircuitPython ports. We discussed this a week or two ago in the weekly CircuitPython meeting, and there was general agreement to remove these for clarity. These ports have not kept up with CircuitPython, except for
esp8266
, which was dropped. If and when we do a port to one of these platforms, we may choose a different directory name so as not to conflict with the MicroPython port name. (For example, we are usingstm32f4
for our port, instead ofstm32
.)These ports have been removed. Each is in one commit, so it may be reverted easily, for whatever reason.
bare-arm
cc3200
esp32
esp8266
minimal
pic16bit
qemu-arm
stm32
teensy
windows
zephyr
These ports remain:
atmel-samd
nrf
stm32f4
unix
Further work in this direction will bring the
unix
port closer to CircuitPython, such as removing dependencies onextmod
in favor ofshared-*
.