Skip to content

Remove non-CircuitPython ports #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 15, 2019
Merged

Conversation

dhalbert
Copy link
Collaborator

Remove non-CircuitPython ports. We discussed this a week or two ago in the weekly CircuitPython meeting, and there was general agreement to remove these for clarity. These ports have not kept up with CircuitPython, except for esp8266, which was dropped. If and when we do a port to one of these platforms, we may choose a different directory name so as not to conflict with the MicroPython port name. (For example, we are using stm32f4 for our port, instead of stm32.)

These ports have been removed. Each is in one commit, so it may be reverted easily, for whatever reason.

  • bare-arm
  • cc3200
  • esp32
  • esp8266
  • minimal
  • pic16bit
  • qemu-arm
  • stm32
  • teensy
  • windows
  • zephyr

These ports remain:

  • atmel-samd
  • nrf
  • stm32f4
  • unix

Further work in this direction will bring the unix port closer to CircuitPython, such as removing dependencies on extmod in favor of shared-*.

@dhalbert dhalbert requested a review from tannewt October 13, 2019 15:11
@dhalbert dhalbert force-pushed the remove-unused-ports branch from 412ff58 to e89bcce Compare October 13, 2019 23:33
tannewt
tannewt previously approved these changes Oct 14, 2019
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Needs one merge before merge.

@arturo182
Copy link
Collaborator

I believe there are submodules that are used only by the ports being removed so they could be removed too, for example "lib/stm32lib" and "lib/berkeley-db-1.xx".

@arturo182
Copy link
Collaborator

Does this also mean some of the old code only used by those ports will be removed too, like the machine modules?

tannewt
tannewt previously approved these changes Oct 14, 2019
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to merge after GitHub CI is happy.

@dhalbert
Copy link
Collaborator Author

@arturo182 extmod, which includes machine, will go away later, after i updated the remaining ports, including the unix port, to not use anything in extmod. We need to move various things in extmod like re and json to shared-*. I can clean up the submodules at that time as well; thanks for pointing those out.

@arturo182
Copy link
Collaborator

Sounds good to me. Nice to see CP dropping dead and unsupported code :)

@dhalbert
Copy link
Collaborator Author

@tannewt, OK, finally built correctly again.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@tannewt tannewt merged commit 6f2e2fa into adafruit:master Oct 15, 2019
@dhalbert dhalbert deleted the remove-unused-ports branch November 4, 2019 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants