-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Top and limit stack addresses #2230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kamtom480 I'm not sure why you resubmitted the PR multiple times, but don't worry about have a "clean" set of commits. It's fine with us to push new commits that fix build problems, typos, etc. |
@dhalbert I just wanted to rerun tests. I didn't want to add new commits. There is a problem with these tests because sometimes they do not work properly. Maybe this is caused by the |
Do you have this button on, say https://github.com/adafruit/circuitpython/pull/2230/checks. I'm not sure if you have to have a certain privilege to have it. |
Your changes should not be affecting the micropython tests at all, I think, because your code is not used when building We have seen these kinds of thread test failures occasionally, but not for a long time, so I'm not sure why they have reappeared. I'm not sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for the refactor.
@dhalbert I don't have this button. |
OK, if it happens again, just ping one of us in the PR and we will re-run the build. |
This PR changes the way to get stack addresses. Now instead of using only values from the linker file, you can define the top and limit address of the stack in the code.
Two new functions have been added:
port_stack_get_limit
andport_stack_get_top
.For
atmel-samd
,nrf
andstm32f4
stack addresses are returned using values from the linker file. Forcxd56
the stack addresses have been taken from the task where CircuitPython is running.