Skip to content

Use MICROPY_PY_SYS_PLATFORM in mpconfigport.h only #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2019
Merged

Use MICROPY_PY_SYS_PLATFORM in mpconfigport.h only #2249

merged 2 commits into from
Oct 28, 2019

Conversation

dhalbert
Copy link
Collaborator

The ItsyBitsy nRF52840 board def used an older style, where MICROPY_PY_SYS_PLATFORM was defined mpconfigboard.h. It should be in mpconfigport.h. This fixes the Itsy 840 board def and also canonicalizes the SPRESENSE port.

@dhalbert dhalbert requested a review from hierophect October 28, 2019 14:43
hierophect
hierophect approved these changes Oct 28, 2019
View reviewed changes
Copy link
Collaborator

@hierophect hierophect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dhalbert dhalbert merged commit 855de94 into adafruit:master Oct 28, 2019
@dhalbert dhalbert deleted the micropy_py_sys_platform branch October 28, 2019 15:59
@dhalbert dhalbert restored the micropy_py_sys_platform branch November 1, 2019 15:39
@dhalbert dhalbert deleted the micropy_py_sys_platform branch November 4, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@hierophect hierophect hierophect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @ladyada @hierophect