Skip to content

Add BUILDING.md document for #2370 #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 19, 2019
Merged

Conversation

rhooper
Copy link

@rhooper rhooper commented Dec 16, 2019

Adds a BUILDING.md document to the repo to help newcomers and long-timers alike remember commands they don't use often.

@rhooper rhooper changed the title Add BUILDING.md document Add BUILDING.md document for #2370 Dec 16, 2019
ladyada
ladyada previously approved these changes Dec 17, 2019
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanx - leaving for others to do final review but seemed ok in my review

Copy link

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things from me...

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments but good otherwise. Thanks!

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@tannewt tannewt requested a review from sommersoft December 18, 2019 19:42
@rhooper
Copy link
Author

rhooper commented Dec 19, 2019

Is there anything outstanding to address in this PR? I think I addressed all the comments.

@tannewt
Copy link
Member

tannewt commented Dec 19, 2019

Nope, just waiting for @sommersoft approval.

@tannewt tannewt merged commit cca5260 into adafruit:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants