Skip to content

STM32: Cpython compatibility flag #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2019
Merged

STM32: Cpython compatibility flag #2439

merged 1 commit into from
Dec 30, 2019

Conversation

hierophect
Copy link
Collaborator

@hierophect hierophect commented Dec 30, 2019

Adds the MICROPY_CPYTHON_COMPAT flag to the STM32 port, which does not currently use the FULL_BUILD setting. Resolves #2433.

I think this might be a good opportunity to discuss the build settings in py/circuitpy_mpconfig.mk, since they're getting a little bloated. Right now we have:

  • CIRCUITPY_FULL_BUILD (everything on the list)
  • CIRCUITPY_SMALL_BUILD (just turns off full build only items)
  • CIRCUITPY_DEFAULT_BUILD (everything not in full build)
  • CIRCUITPY_MINIMAL_BUILD (turns off default build items)
  • CIRCUITPY_ALWAYS_BUILD (items with no HAL component that always get built)

Would it be simpler here to remove the "turn off" flags and have ports define the highest level they want to include? IE just three items, FULL_BUILD, DEFAULT_BUILD, MINIMAL_BUILD. py/circuitpy_mpconfig.h would be changed to detect the absence of FULL_BUILD.

@dhalbert
Copy link
Collaborator

I agree the BUILD flags should be tuned up (I was thinking of ALWAYS, MINIMAL, 192kB, 256kB, FULL). Worth opening an issue, but not urgent.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STM32: possible problem with strings and adafruit_minimqtt library (AdafruitIO)
2 participants