STM32: Cpython compatibility flag #2439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the MICROPY_CPYTHON_COMPAT flag to the STM32 port, which does not currently use the FULL_BUILD setting. Resolves #2433.
I think this might be a good opportunity to discuss the build settings in
py/circuitpy_mpconfig.mk
, since they're getting a little bloated. Right now we have:Would it be simpler here to remove the "turn off" flags and have ports define the highest level they want to include? IE just three items, FULL_BUILD, DEFAULT_BUILD, MINIMAL_BUILD.
py/circuitpy_mpconfig.h
would be changed to detect the absence of FULL_BUILD.