Skip to content

Build static binaries of mpy-cross for desktop linux, desktop windows, mac, and raspbian #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 29, 2020

Conversation

jepler
Copy link

@jepler jepler commented Jan 25, 2020

these are attached as artifacts of the github actions build. More work would be needed to get them to a useful spot, such as on circuitpython.org. Related to adafruit/circuitpython-org#53

Testing performed: that all the programs run and print a message that no input file was provided, when run on the appropriate host. (wine64 in the case of the windows executable, I don't have any native windows machine handy)

@jepler jepler force-pushed the build-mpy-cross-static-linux-win64 branch from 50c571a to b5b7b6f Compare January 25, 2020 21:43
@sommersoft
Copy link

@jepler, you sure made quick work of this!

I do have some higher-level suggestions, which likely require some other points of view besides mine.

  • Since mpy-cross really only tracks major version increases, I wouldn't have it compiled with every PR/push. I would place these Actions tasks either into the create_website_pr.yml/tools/build_release_files.py, or in a separate workflow that was triggered on release.

  • The "get it to circuitpython.org" question would be easily answered by either adding to tools/build_board_info.py or making a similar task sequence for mpy-cross. Then circuitpython.org would have a simple JSON mapping to direct downloads.

@jepler
Copy link
Author

jepler commented Jan 26, 2020

I have prepared some rules for building mac mpy-cross. I did not static link this one, and I have no way of running/testing it. if someone can pick the binary up and give it a run, please let us know. Note that it builds on Catalina so for all I know Catalina is a minimum version to run it; I don't know much about how cross-version stuff goes on macos. (sensing a theme yet?)

@jepler
Copy link
Author

jepler commented Jan 26, 2020

@sommersoft absolutely I'm open to re-working this into the form that is most useful. This is a proof of concept that we can build the binaries we want within github actions, and the rules can be copied (or cut) and pasted to a more appropriate place for sure!

@dhalbert
Copy link
Collaborator

I think I build MacOS mpy-cross statically just by adding --static, though that may have been under msys on Windows.

@jepler jepler changed the title Build static binaries of mpy-cross for desktop linux, desktop windows, and raspbian Build static binaries of mpy-cross for desktop linux, desktop windows, mac, and raspbian Jan 27, 2020
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Copy link

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jepler. Like you said, the integration can come later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants