Skip to content

Freeze adafruit_requests and adafruit_esp32spi into mimxrt1011 Feathers #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2020
Merged

Freeze adafruit_requests and adafruit_esp32spi into mimxrt1011 Feathers #2665

merged 2 commits into from
Feb 29, 2020

Conversation

arturo182
Copy link
Collaborator

No description provided.

@arturo182 arturo182 added the mimxrt10xx iMX RT based boards such as Teensy 4.x label Feb 28, 2020
@arturo182 arturo182 requested a review from tannewt February 28, 2020 23:37
ladyada
ladyada previously approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yezplz :)

@arturo182
Copy link
Collaborator Author

Note, this is only for my 1011 Feather, not the M7 1011, should I freeze these into that one too?

@ladyada
Copy link
Member

ladyada commented Feb 28, 2020

yep!

@arturo182 arturo182 changed the title Freeze adafruit_requests and adafruit_esp32spi into feather_mimxrt1011 Freeze adafruit_requests and adafruit_esp32spi into mimxrt1011 Feathers Feb 28, 2020
@ladyada
Copy link
Member

ladyada commented Feb 28, 2020

ok by the time i get home this should be ready to merge :)

@arturo182
Copy link
Collaborator Author

@dhalbert was a bit reluctant about merging stuff just before the 5.0.0 release, but up to you :)

@ladyada
Copy link
Member

ladyada commented Feb 29, 2020

ill let @dhalbert decide as this is not code related and imx is super alpha 😀

@dhalbert
Copy link
Collaborator

I have already made a 5.0.x branch, so we are free to merge new stuff into master, and I'll go ahead. We can choose to merge these and further changes into 5.0.x for 5.0.0 now or later. I'm thinking about maybe making an rc.1 soon just to test the new download links, so I might merge this in to help test that.

@dhalbert dhalbert merged commit 29e4472 into adafruit:master Feb 29, 2020
@arturo182 arturo182 deleted the esp32_freeze branch February 29, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
mimxrt10xx iMX RT based boards such as Teensy 4.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arturo182 @ladyada @dhalbert