-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add new board for atmel-samd port: bdmicro_vina-m0 #2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ports/atmel-samd/boards/bdmicro_vina_m0/board.c ports/atmel-samd/boards/bdmicro_vina_m0/mpconfigboard.h ports/atmel-samd/boards/bdmicro_vina_m0/mpconfigboard.mk ports/atmel-samd/boards/bdmicro_vina_m0/board.c This board includes the newly added MX25L51245G 64MB SPI flash chip for the CircuitPython file system. Also included is the PCF2129T/2,518 high accuracy, battery backed, RTC. Also includes an independent USB HOST connector in addition to USB DEVICE making it easy to connect USB peripherals. Designed mainly as a general purpose module to piggy back onto application-specific boards, it can also run low power standalone in harsh environments for data logging and other control applications using an appropriate enclosure. Has been extensively tested with CircuitPython and works well.
My apologies ... in my initial pull request to add the new board, I neglected to add the board to the workflows/build.yml, and the automated test failed. I made that change in my fork and somehow it magically showed up above. Is that now part of the pull request? Do I need to do anything else to get that change into this pull request? And how to restart the automated tests? |
Hi @bd34n! No problem iterating. The PR will match your |
Thank you, @tannewt. I should have realized the tab issue myself. That bites me on a regular basis editing yaml using emacs. And has prompted me to change my .emacs defaults to disable indent with tabs mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one more tiny request. Please don't use - in the board name because we use - to separate parts of the filenames. (We already have two that use dashes but I'd prefer not to have more.)
So, please make it bdmicro_vina_m0
. Thanks!
Ok,, thank you for that feedback. I didn't know. I wondered, though - I noticed that most boards all used underbars. I also noticed a few they used a hyphen, so I thought it while not common, it was ok. I have renamed the board, rebuilt locally and tested the resulting firmware. And also updated the workflows/build.yml file - didn't want to forget that again! :-) Tests are running now. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for understanding! Looks good! Merging now.
Excellent, thank you very much, @tannewt !! |
Add new board BDMICRO 'Vina M0'.
This board includes the newly added MX25L51245G 64MB SPI flash chip for the CircuitPython file system. Has been extensively tested with CircuitPython and works well.
Thank you for reviewing!