Skip to content

Add new board for atmel-samd port: bdmicro_vina-m0 #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2020
Merged

Add new board for atmel-samd port: bdmicro_vina-m0 #2737

merged 6 commits into from
Mar 27, 2020

Conversation

bd34n
Copy link

@bd34n bd34n commented Mar 27, 2020

Add new board BDMICRO 'Vina M0'.

This board includes the newly added MX25L51245G 64MB SPI flash chip for the CircuitPython file system. Has been extensively tested with CircuitPython and works well.

Thank you for reviewing!

bd34n added 3 commits March 26, 2020 20:15
ports/atmel-samd/boards/bdmicro_vina_m0/board.c
ports/atmel-samd/boards/bdmicro_vina_m0/mpconfigboard.h
ports/atmel-samd/boards/bdmicro_vina_m0/mpconfigboard.mk
ports/atmel-samd/boards/bdmicro_vina_m0/board.c

This board includes the newly added MX25L51245G 64MB SPI flash chip
for the CircuitPython file system. Also included is the PCF2129T/2,518
high accuracy, battery backed, RTC. Also includes an independent USB
HOST connector in addition to USB DEVICE making it easy to connect USB
peripherals. Designed mainly as a general purpose module to piggy back
onto application-specific boards, it can also run low power standalone
in harsh environments for data logging and other control applications
using an appropriate enclosure.

Has been extensively tested with CircuitPython and works well.
@bd34n
Copy link
Author

bd34n commented Mar 27, 2020

My apologies ... in my initial pull request to add the new board, I neglected to add the board to the workflows/build.yml, and the automated test failed. I made that change in my fork and somehow it magically showed up above. Is that now part of the pull request? Do I need to do anything else to get that change into this pull request?

And how to restart the automated tests?

@tannewt
Copy link
Member

tannewt commented Mar 27, 2020

Hi @bd34n! No problem iterating. The PR will match your master branch. The tests should automatically run. I have a feeling you need to use spaces instead of a tab and then the test will run. (It is highlighted red in the diff on GitHub.)

@bd34n
Copy link
Author

bd34n commented Mar 27, 2020

Thank you, @tannewt. I should have realized the tab issue myself. That bites me on a regular basis editing yaml using emacs. And has prompted me to change my .emacs defaults to disable indent with tabs mode.

@tannewt tannewt self-requested a review March 27, 2020 16:52
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more tiny request. Please don't use - in the board name because we use - to separate parts of the filenames. (We already have two that use dashes but I'd prefer not to have more.)

So, please make it bdmicro_vina_m0. Thanks!

@bd34n
Copy link
Author

bd34n commented Mar 27, 2020

Ok,, thank you for that feedback. I didn't know. I wondered, though - I noticed that most boards all used underbars. I also noticed a few they used a hyphen, so I thought it while not common, it was ok. I have renamed the board, rebuilt locally and tested the resulting firmware. And also updated the workflows/build.yml file - didn't want to forget that again! :-) Tests are running now.

Thanks!

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for understanding! Looks good! Merging now.

@tannewt tannewt merged commit eeca3b1 into adafruit:master Mar 27, 2020
@bd34n
Copy link
Author

bd34n commented Mar 27, 2020

Excellent, thank you very much, @tannewt !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants