Rename Protomatter to RGBMatrix #2775
Conversation
|
This also has the changes from #2774 |
|
User facing names: Constructing and using: |
jepler
changed the title
| //| | ||
| //| .. class:: Protomatter(width, bit_depth, rgb_pins, addr_pins, clock_pin, latch_pin, output_enable_pin, *, doublebuffer=True, framebuffer=None) | ||
| //| .. class:: RGBMatrix(width, bit_depth, rgb_pins, addr_pins, clock_pin, latch_pin, output_enable_pin, *, doublebuffer=True, framebuffer=None) |
There was a problem hiding this comment.
I thought we added height here. Did it get lost in the PR shuffle?
There was a problem hiding this comment.
Docs got out of date. Fixed now?
|
At this point, Actions reports '80 successful, 43 queued, and 1 in progress checks'. build-arm (circuitplayground_bluefruit) started 19h 17m 4s ago and has been running the step 'build' for 19h 15m 35s. The log for the build step can't be viewed. I'm going to cancel and re-run, and if that doesn't break it loose, I'll push a nonessential change. Hopefully one of those will get this on the road again. |
I originally believed that there would be a wrapper library around it, like with _pixelbuf; but this proves not to be the case, as there's too little for the library to do.
This is a quick rename, it changes the user-facing names but not the internal names of things.
This gets all the purely internal references. Some uses of protomatter/Protomatter/PROTOMATTER remain, as they are references to symbols in the Protomatter C library itself.
... allocate_display_bus_or_raise() uses fixed storage, not heap storage.
|
Rebased and "make translate"d again. |
|
In my own fork's actions, 9bfe6b7 (framebufferio: update copyright information) succeeded instead of hanging: https://github.com/jepler/circuitpython/actions/runs/80760861 -- however, for circuitpython it was hung and I cancelled it. |
|
@tannewt Again, this PR build hung. I've made another non-essential change. |
|
@tannewt actions finally finished this time! |
In the interest of time, this only renames the user facing parts, a cleanup PR to rename internally will come later on.This renames the user-facing parts as well as the identifiers that are internal to CircuitPython.
Closes: #2776