Skip to content

Update tinyusb #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2020
Merged

Update tinyusb #2805

merged 4 commits into from
Apr 27, 2020

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Apr 24, 2020

It now requires us to call the interrupt handler.

@tannewt tannewt requested a review from hathach April 24, 2020 01:04
@tannewt tannewt added this to the 5.x.0 - Features milestone Apr 24, 2020
hathach
hathach previously approved these changes Apr 24, 2020
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great as it should be. We could remove an empyt ifdef with litex port, but it is not a big deal. I am not sure why nRF port ci failed due to lack of prototype for tud_int_handler. It should be present if tusb.h is included.

@tannewt
Copy link
Member Author

tannewt commented Apr 25, 2020

@hathach I sorted out the include and the build passes now. So, please take another look on your monday.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, please merge anytime you like

@tannewt tannewt merged commit 9e4b94f into adafruit:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants