-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ulab: actually update the submodule #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR#2802 missed the submodule update itself.
We may now face the first need to disable a ulab module, such as the newly added comparison module. At least the espruino pico board no longer builds with this PR, due to overflowing flash. |
@jepler @tannewt I am willing to change the sub-module structure, if necessity be. I would, perhaps, suggest at this point to run a poll on which functions people need, and use the results as a guideline. |
this non-"express" board is nearly full. Right now it's actually possible just to disable the "compare" module, but as this leaves it packed pretty full I prefer to fully disable it in order to avoid the topic returning again soon.
I chose to disable ulab altogether on the espruino pico. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Removing on Espruino-pico is a fine choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Reminds me to re-check -flto, I can't remember why I didn't enable that last time but it may have been resolved by other recent makefile/linker changes.
Are we able to disable submodules of |
@tannewt yes, we are able to selectively disable parts of ulab. I originally investigated that as a solution, but with the new ulab.comparison module deactivated it left only about 2kB (I forget exactly) of flash free. My gut said, better to fully disable ulab on this board than return within days or weeks to revisit the issue. If we get lto and it reclaims 20+kB as I suspect it would, that would be a great time to re-revisit it. However, I can change this PR to disable as little as possible, if that's what you prefer. Please merge or let me know. |
This is fine. Thanks! |
This brings up another issue, which, perhaps, deserves its own thread: it would be really great, if users could customise their own I believe, this would benefit everyone, because |
@v923z We should discuss this on a separate issue. Generally, we don't support users integrating their own C code into CircuitPython. |
#2802 missed the submodule update itself.