-
Notifications
You must be signed in to change notification settings - Fork 1.3k
mimxrt10xx: add one-directional SPI #2841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request about the CFLAG changes.
Ready for re-review. @arturo182 I have pin claiming/resetting in the works so I didn't add the comments back in since they'll be replaced with real versions in that PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too!
This PR allows the SPI line to be defined as SCK and either MOSI or MISO, removing the requirement for both. It also adds SPI index reservation to the module, meaning that additional SPIs cannot be defined which "poach" the original peripheral, changing its settings and potentially sending erroneous signals over previously configured pins.
Tested on the EVK 1010 and I think it's fine? I don't have a good unidirectional SPI device other than my SSD1306 screen, and I can't get that to work on the master branch either at the moment. Looking at the signals with a Saleae they seem good, no differences between 3 line and 2 line. Any testing assistance would be appreciated.
Resolves #2482