Skip to content

mimxrt10xx: add one-directional SPI #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2020
Merged

mimxrt10xx: add one-directional SPI #2841

merged 2 commits into from
May 6, 2020

Conversation

hierophect
Copy link
Collaborator

@hierophect hierophect commented May 1, 2020

This PR allows the SPI line to be defined as SCK and either MOSI or MISO, removing the requirement for both. It also adds SPI index reservation to the module, meaning that additional SPIs cannot be defined which "poach" the original peripheral, changing its settings and potentially sending erroneous signals over previously configured pins.

Tested on the EVK 1010 and I think it's fine? I don't have a good unidirectional SPI device other than my SSD1306 screen, and I can't get that to work on the master branch either at the moment. Looking at the signals with a Saleae they seem good, no differences between 3 line and 2 line. Any testing assistance would be appreciated.

Resolves #2482

@hierophect hierophect requested review from arturo182 and tannewt May 1, 2020 17:19
Copy link
Collaborator

@arturo182 arturo182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments otherwise looks good!

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request about the CFLAG changes.

@hierophect hierophect requested a review from tannewt May 5, 2020 14:05
@hierophect hierophect requested a review from arturo182 May 5, 2020 16:46
@hierophect
Copy link
Collaborator Author

Ready for re-review. @arturo182 I have pin claiming/resetting in the works so I didn't add the comments back in since they'll be replaced with real versions in that PR.

Copy link
Collaborator

@arturo182 arturo182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@tannewt tannewt merged commit 4519dde into adafruit:master May 6, 2020
@hierophect hierophect deleted the mimxrt-spi-oneway branch May 6, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mimxrt10xx: Allow one-way SPI
3 participants