STM32: Add displayio to F7/H7 #2842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
May 1, 2020
|
@tannewt ping for re-review |
tannewt
approved these changes
May 4, 2020
|
Tested on STM32 Feather F405 and Atmel-SAMD Feather M4 Express for regression, works on both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DisplayIO support to the F7 and H7 STM32 families. Should enable some fairly impressive screen use given the large RAM sizes and speeds of these chipsets.
Includes some minor changes to remove DisplayIO's strict dependency on Pulsio. Before, DisplayIO required PulseIO to be implemented as empty stubs but with the CIRCUITPY_PULSIO macro still turned on, which was confusing from a documentation perspective and not especially necessary since it could smoothly default to DigitalIO backlights already.
Another minor change included is tripling the default filesystem size of the H7. It may be beneficial in the future to add some kind of board-level setting to adjust filesystem size on these chips, since H7 dev boards often forgo SPI flash since the on-board flash is so huge (1MB). For now it's simply large enough to cleanly fit all the DisplayIO .mpy libraries without crashing.
Tested on Nucleo H743, Nucleo H767 with a SSD1306 with success.