vectorio: speed up polygon #2888
Merged
+197
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
May 13, 2020
kvc0
force-pushed
the
vectorio-polygon-speed
branch
from
e2dabae to
03bd9eb
Compare
tannewt
requested changes
May 14, 2020
Ah there's that silly button. Fix away and thanks :-D |
|
@WarriorOfWire For some reason I couldn't push to your branch still. I pushed the merge to my corresponding branch if you want to snag it from there. |
kvc0
force-pushed
the
vectorio-polygon-speed
branch
from
462355c to
18324e4
Compare
|
This PR got too dirty; I've rebased the intended changes on master to keep the changelog clean. Should be good to go. |
This change takes polygon from 126k pixels per second fill to 240k pps fill on a reference 5 point star 50x66px polygon, updating both location and shape at 10hz. Tested on an m4 express feather. As a curiosity, the flat-out fill rate of a shape whose get_pixel is `return 0;` fills just shy of 375k pixels per second.
kvc0
force-pushed
the
vectorio-polygon-speed
branch
from
18324e4 to
a78f245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes polygon from 126k pixels per second fill to 240k pps fill
on a reference 5 point star 50x66px polygon, updating both location and shape
at 10hz. Tested on an m4 express feather.
As a curiosity, the flat-out fill rate of a shape whose get_pixel is
return 0;fills just shy of 375k pixels per second.
Baseline:
This change: