Add initial ESP32S2 support #2910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic blinky works but doesn't check pins.
hathach
reviewed
May 16, 2020
d-c-d
reviewed
May 16, 2020
jepler
previously approved these changes
May 19, 2020
There was a problem hiding this comment.
Because I don't have the hardware or toolchain to test on, I mostly looked at the changes introduced outside of ports/esp32s2. They seem sensible. I asked Scott about a few on Discord for more information.
There's sure to be more work to do in the port, but this is a great step and looks like a low chance of disrupting other ports.
dhalbert
previously approved these changes
May 19, 2020
ports/atmel-samd/boards/circuitplayground_express_crickit/mpconfigboard.h
Outdated
Show resolved
Hide resolved
tyomitch
pushed a commit
to tyomitch/circuitpython
that referenced
this pull request
May 6, 2021
This adds to the ESP8266 tutorial instructions explaining which pins to pull low to enter programming mode. Commit made originally by @ARF1 in adafruit#2910. Signed-off-by: Damien George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.