Skip to content

update frozen libs #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

dhalbert
Copy link
Collaborator

No description provided.

@dhalbert dhalbert requested a review from tannewt May 16, 2020 20:46
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish github would explain submodule updates by showing the submodule's log, not the diffstat.

Author: Dan Halbert <[email protected]>
Date:   Sat May 16 11:20:25 2020 -0400

    update frozen libs

Submodule frozen/Adafruit_CircuitPython_BLE 96774b15d..5d584576e:
  > Merge pull request #81 from dhalbert/max_length
Submodule frozen/Adafruit_CircuitPython_BusDevice 0b0d1e999..e9411c424:
  > Merge pull request #50 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #48 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #47 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
  > Merge pull request #45 from dhalbert/fix-end-values
  > Merge pull request #43 from dhalbert/avoid-alloc
  > Merge pull request #40 from adafruit/dherrada-patch-2
  > Merge pull request #41 from adafruit/dherrada-patch-3
Submodule frozen/Adafruit_CircuitPython_CircuitPlayground 2cf0f40ab..e9f15d615:
  > Merge pull request #91 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #90 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #89 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
  > Merge pull request #87 from kattni/readme-update
  > Merge pull request #86 from kattni/express-notimplementederror
Submodule frozen/Adafruit_CircuitPython_Crickit 09bd10e94..0e1230676:
  > Merge pull request #28 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #27 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #26 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
Submodule frozen/Adafruit_CircuitPython_DotStar 84eadeafa..f4f66fa03:
  > Merge pull request #48 from dunkmann00/pixelbuf
  > Merge pull request #46 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #45 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #44 from sommersoft/patch_coc
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
Submodule frozen/Adafruit_CircuitPython_ESP32SPI f523b2316..94b03517c:
  > Merge pull request #97 from dearmash/master
  > Merge pull request #98 from brentru/update-simpletest
  > Merge pull request #89 from anecdata/gpio
  > Merge pull request #96 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #93 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #92 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
  > Merge pull request #91 from FoamyGuy/master
  > Merge pull request #66 from mytechnotalent/ESP32-MAC-order-library-fix
Submodule frozen/Adafruit_CircuitPython_HID f044548d6..65fb213b8:
  > Merge pull request #51 from larsks/bug/usb_hid
  > Merge pull request #50 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #47 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #45 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
Submodule frozen/Adafruit_CircuitPython_IRRemote 9dac9628e..d435fc9a9:
  > Merge pull request #36 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #35 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #34 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
  > Merge pull request #33 from mfeif/master
Submodule frozen/Adafruit_CircuitPython_LIS3DH 42a55eafc..457aba6dd:
  > Merge pull request #60 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #59 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #58 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
Submodule frozen/Adafruit_CircuitPython_LSM6DS 24224cc90..ee8f2187d:
  > Merge pull request #16 from adafruit/memory_fix
Submodule frozen/Adafruit_CircuitPython_Motor ddcd1e715..5fd72fb96:
  > Merge pull request #40 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #39 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #38 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
  > Merge pull request #37 from geekguy-wy/removing_deinits
Submodule frozen/Adafruit_CircuitPython_NeoPixel 10db851c8..59add970c:
  > Merge pull request #83 from adafruit/tannewt-patch-1
  > Merge pull request #82 from dunkmann00/pixelbuf
  > Merge pull request #81 from adafruit/black-update
  > Merge pull request #79 from adafruit/black-update
  > Merge pull request #78 from adafruit/pylint-update
  > Merge pull request #77 from sommersoft/patch_coc_2
  > Merge pull request #76 from sommersoft/patch_coc
  > Merge pull request #75 from sommersoft/build_yml_local_pip
Submodule frozen/Adafruit_CircuitPython_Register c525eedeb..56358b449:
  > Merge pull request #38 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #37 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #36 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
Submodule frozen/Adafruit_CircuitPython_Requests e8a759719..41de8b3c0:
  > Merge pull request #27 from brentru/add-cellular
  > Merge pull request #26 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #24 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #23 from sommersoft/patch_coc
  > Merge pull request #22 from brentru/update-examples-for-ethernet
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
  > Merge pull request #21 from jimbobbennett/master
Submodule frozen/Adafruit_CircuitPython_SD efd548b1e..96ee9954a:
  > Merge pull request #33 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #32 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #31 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
Submodule frozen/Adafruit_CircuitPython_Thermistor ac83a3dc7..b5bbdbd56:
  > Merge pull request #14 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #13 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #12 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
Submodule frozen/Adafruit_CircuitPython_seesaw dc01285aa..76c0dd132:
  > Merge pull request #51 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request #50 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request #48 from sommersoft/patch_coc
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
  > Merge pull request #47 from makermelissa/master

@dhalbert dhalbert merged commit 8fd733c into adafruit:master May 18, 2020
@dhalbert dhalbert deleted the update-frozen-libs-2020-05-16 branch May 18, 2020 02:23
@tannewt
Copy link
Member

tannewt commented May 18, 2020

Did you make sure pixelbuf is enabled on all boards with NeoPixel frozen in? Otherwise one will still need to install pypixelbuf.

@anecdata
Copy link
Member

Ditto for Dotstar?

@jepler
Copy link

jepler commented Nov 30, 2020

I belatedly checked and each build that freezes in Adafruit_CircuitPython_NeoPixel builds in _pixelbuf, according to the support matrix.

pirkey_m0 freezes DotStar but does NOT have _pixelbuf. Other DotStar-freezing builds have _pixelbuf. Does this mean that pirkey_m0 should remove DotStar? I doubt it can add _pixelbuf, but I could be wrong. @tannewt mind filing a PR that calls for the right thing to be done?

@jepler
Copy link

jepler commented Nov 30, 2020

My mistake, the line to freeze dotstar into pirkey_m0 is commented out, so no action is needed. My over-eager grep found it and I didn't look carefully.

@dglaude
Copy link

dglaude commented Nov 30, 2020

This raise a question about unused or never released board...
pIRkey was never released by @ladyada as a product, maybe just in a Top Secret with a few prototype.
This could be the story for PyGamer Advance.

Those are ghost board visible on https://circuitpython.org/downloads
If those start to make problem, it is a bit sad.

@tannewt
Copy link
Member

tannewt commented Nov 30, 2020

This raise a question about unused or never released board...
pIRkey was never released by @ladyada as a product, maybe just in a Top Secret with a few prototype.
This could be the story for PyGamer Advance.

Those are ghost board visible on https://circuitpython.org/downloads
If those start to make problem, it is a bit sad.

We'll remove them if they start breaking the build but no need to do any work before that.

The downloads page is sorted by download count so that we can have all levels of boards from professional to one-off hobbyist. I don't want to add any sort of requirement to being listed besides having mainline support merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants