_bleio: support anonymous advertising #2919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
May 18, 2020
|
I added a new property Additionally, I created a new property |
Add a new parameter to the `start_advertising()` function to enable anonymous advertising. This forces a call to `sd_ble_gap_privacy_set()` with `privacy_mode` set to `BLE_GAP_PRIVACY_MODE_DEVICE_PRIVACY` and `private_addr_type` set to `BLE_GAP_ADDR_TYPE_RANDOM_PRIVATE_RESOLVABLE`. With this, addresses will cycle at a predefined rate (currently once every 15 minutes). Signed-off-by: Sean Cross <[email protected]>
Add a field to allow specifying a timeout when initiating advertising. As part of this, add a new property to determine if the device is still advertising. Additionally, have the `anonymous` property require a timeout, and set the timeout to the maximum possible value if no timeout is specified. Signed-off-by: Sean Cross <[email protected]>
There is now an adapter timeout message. Signed-off-by: Sean Cross <[email protected]>
xobs
force-pushed
the
bleio-anonymous-advertising
branch
from
e20cc02 to
f56188c
Compare
|
Thanks for the feedback, @dhalbert . I've made all of those changes as requested. |
dhalbert
requested changes
May 19, 2020
The timeout value is calculated by the common-hal layer now, so we don't need to be quite so clever about calculating it here. Signed-off-by: Sean Cross <[email protected]>
|
I pushed to the wrong repo. Oops. Also, alright, I reverted that change. I already added a note to the documentation regarding defaults of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experimental patch adds a new parameter to
_bleio.adapter.start_advertising():anonymous.This boolean parameter defaults to
False. When set toTrue, it enables privacy mode by callingsd_ble_gap_privacy_set().I have tested this on my device, and I confirm that it works -- the address is randomized, and is rotated every 15 minutes. A second device is capable of connecting to a GATT service and communicating.
Unanswered questions:
0which uses the Nordic defaultsIRKbe exposed anywhere, and does this affect bonding at all?