Skip to content

Fix ReadTheDocs after switching to stubs + autoapi. #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2020

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented May 18, 2020

@tannewt tannewt requested a review from sommersoft May 18, 2020 23:39
sommersoft
sommersoft previously approved these changes May 19, 2020
Copy link

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Looking at the raw log on RTD, I see that it initially installs Sphinx<2 and our requirements.txt is still pinned to 1.8.5. Do we want to upgrade RTD builds to match the CI builds? Obivously, its not broken so not a super-important or blocking issue...

@tannewt
Copy link
Member Author

tannewt commented May 19, 2020

I stopped us pinning to 1.8.5 but RTD is still I think. I updated recommonmark and it worked ok. New build is here: https://readthedocs.org/projects/tannewt-circuitpython/builds/11074950/

Copy link

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it doesn't look like RTD has a config option either. Again, not broken so not anything to block on.

@sommersoft sommersoft merged commit bdc5a6b into adafruit:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants