ndgGarage ndbit6 v2 #3101
Merged
ndgGarage ndbit6 v2 #3101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Jul 2, 2020
| @@ -0,0 +1,14 @@ | |||
| LD_FILE = boards/samd21x18-bootloader.ld | |||
| USB_VID = 0x239A | |||
| USB_PID = 0x8066 | |||
There was a problem hiding this comment.
Please use a different PID for new boards. (This is the same as the original: https://github.com/adafruit/circuitpython/blob/main/ports/atmel-samd/boards/ndgarage_ndbit6/mpconfigboard.mk#L3 )
|
Hi,
I'll request a new PID for this revision and submit a new PR.
I just set up a preliminary page on Hackaday. The link is
https://hackaday.io/project/173537-feathersnow-v2
Thanks,
-Henry
…On Thu, 2 Jul 2020 at 15:00, Scott Shawcroft ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks for the new board! Do you have a link to info about the new board?
------------------------------
In ports/atmel-samd/boards/ndgarage_ndbit6_v2/mpconfigboard.mk
<#3101 (comment)>
:
> @@ -0,0 +1,14 @@
+LD_FILE = boards/samd21x18-bootloader.ld
+USB_VID = 0x239A
+USB_PID = 0x8066
Please use a different PID for new boards. (This is the same as the
original:
https://github.com/adafruit/circuitpython/blob/main/ports/atmel-samd/boards/ndgarage_ndbit6/mpconfigboard.mk#L3
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3101 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6O3PIBV4J2VJSGCXRVHMLRZTYOLANCNFSM4ON6YUZQ>
.
|
|
Have updated my branch with a new USB PID. Not sure if I should create a new PR? |
No new PR is necessary. (A PR is rarely perfect the first time 😃) You pushed the change and we will re-review. |
|
I saw the pre-built failed again due to the CRLF or the end of file things.
I am using a mac. Is it possible to have automatic conversion when I commit
the changes to my branch? I know that .gitattribute can be used for this
purpose. But how?
…On Sat, 4 Jul 2020 at 11:03, Dan Halbert ***@***.***> wrote:
Have updated my branch with a new USB PID. Not sure if I should create a
new PR?
No new PR is necessary. (A PR is rarely perfect the first time 😃) You
pushed the change and we will re-review.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3101 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6O3PJS6YX7GHUIEMCCHN3RZ5OHLANCNFSM4ON6YUZQ>
.
|
|
I think it's because you added an extra blank line at the end of these files: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of ndGarage ndbit6 is created. Thanks.