Add 2 boards nRF52840 M.2 devkit and M60 Keyboard

[xiongyihui]

• nRF52840 M.2 devkit is a developer kit based on a removable nRF52840 M.2 module and is designed for prototyping.
• M60 is a USB & Bluetooth 60% keyboard running CircuitPython.

[ladyada]

hi - do you have permission from nordic to use their VID?

https://devzone.nordicsemi.com/f/nordic-q-a/26196/obtain-a-pid-for-an-nrf24lu1-based-product

[xiongyihui]

Has discussed the VID issue before. It seems Nordic allows customers to use its VID in a product with its chip. Of course, there is a risk.

You can use our Nordic's Vendor ID. However, you will have a case that other customer also use our Vendor ID and use the same Product ID that you choose.

from https://devzone.nordicsemi.com/f/nordic-q-a/33851/nrf52840---usb-vendor-id-and-usb-product-id

[ladyada]

considering the number of products you are making, we think you should get a VID at this point - other companies such as seeed and sparkfun and arduino and adafruit all have a VID

[xiongyihui]

Got your thought. I will try to get a unique VID & PID.

[tannewt]

Once you get a VID for MakerDiary you'll have 2**16 PIDs for all of your products and more. Also, I'm available on WeChat as tannewt if you want help over chat.

[xiongyihui]

Our Seeed friends have kindly allowed us to use their VID with a range of PIDs.
@ladyada Is it OK that I use Seeed's VID 0x2886 and the PID 0xf001 for our products in this project? One PID should be enough as all these products are based on nRF52840 and have the same driver for an OS.
You may ask why not buy a VID. Although being comparing to seeed, sparkfun, arduino and adafruit, we are still a small team with 3 persons and can not afford a USB VID yet. It doesn't break any rule by using Nordic's VID or Seeed's VID.

@tannewt have sent a request to add me on wechat

[ladyada]

we purchased a VID when we were only a few people too, about 10 years ago. if you are selling USB products, it is the cost of doing business, just like it costs money to buy components and PCBs :)

you can totally use VID/PIDs donated by others. it is important that each circuitpython board has unique VID/PID. having duplicates will cause problems for customers. please ask seeed to grant you individual PID's for each item so they are unique.

[ladyada]

thank you :)

[tannewt]

Just a couple questions and suggestion about using the RGB led for CircuitPython status. Here is an example: https://github.com/adafruit/circuitpython/blob/main/ports/nrf/boards/particle_argon/mpconfigboard.h#L35-L37

[xiongyihui]

Are MICROPY_HW_RGB_LED_RED, MICROPY_HW_RGB_LED_GREEN and MICROPY_HW_RGB_LED_BLUE necessary? Didn't find them being used.

[tannewt]

Are MICROPY_HW_RGB_LED_RED, MICROPY_HW_RGB_LED_GREEN and MICROPY_HW_RGB_LED_BLUE necessary? Didn't find them being used.

Looks like I have the wrong defines. Looks like it should be CP_RGB_STATUS_R: https://github.com/adafruit/circuitpython/blob/main/supervisor/shared/rgb_led_status.c#L147

[tannewt]

Thank you!

The base branch was changed.

[tannewt]

FYI, I changed the base branch to main. We no longer are using master.

[tannewt]

I also did the merge in your master branch so make sure and pull from GitHub if you use that branch locally.

[tannewt]

Thank you! We're excited for these boards!

[xiongyihui]

OK. Many thanks.