Updated Group.c to correct bug with insert into displayio.Group #3214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve the bug when inserting an element at the end of an existing group. See issue: #3129 (comment)
In this PR, per your suggestions I check if the requested insert index is equal to the length of the group. If so, then call append, else call insert.
I hunted around the code for the proper type conversions, but I am unsure if I am doing the type conversion correctly.
** Please double-check since I am not familiar with any of the data types that are used here.
I built this and verified on an Itsy-Bitsy NRF52840
Here is how I verified the code:
@FoamyGuy whenever this bug is corrected, you can simplify the workaround to the label.py related where you had to double-check the length of the group to decide whether to use
group.append
orgroup.insert
.