Better support for utf-8 repl #3243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses #3242 |
|
See #3230 (comment) and following.
Disabling |
Currently when a utf8 character that is bigger than 1 byte is typed in the repl, it isn't handled how it should be. If you try to move the cursor in any direction the text gets messed up. This fixes that.
dunkmann00
force-pushed
the
support-utf8-repl-take-one
branch
from
80c494d to
e00e95e
Compare
dunkmann00
force-pushed
the
support-utf8-repl-take-one
branch
from
e00e95e to
398be76
Compare
|
Found a problem with computing the line length, that is fixed with the latest commit. I also rebased this to main and it appears to be fitting on all boards now after the changes @jepler made to make builds smaller. |
|
Thanks for the note; yes this does look useful for us as well! |
Closed
This was referenced Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some 'utf-8 aware' code to the repl. Anytime the cursor moves or something is typed or deleted, we have to keep track of the number of utf-8 continuation bytes that are involved. This way, the repl behaves as you would expect it to even with characters that are not ascii.
I know space is tight on some of the smaller boards so I tried my best to minimize the impact on code size with this but, it still is causing a few build failures.
I've tested this out on an itsybitsy_m4/m0_express and it seems good on both of those boards.
Let me know what you think!