-
Notifications
You must be signed in to change notification settings - Fork 1.3k
RFM9x -- freeze library into build #3251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jerryneedell I'll be testing this today, added to TODOs |
@jerryneedell Was too optimistic, will get to this tomorrow |
@jerryneedell Ok, I checked out the branch and built the Importing
|
Not sure I understand where the “images” folder came from. You have a different commit than I do -- see comment below. |
works for me
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works! Thanks for making room
@jerryneedell I don't see any learn guides/projects which utilize the DHT+LoRa RFM9x (aside from TTN ones, and those should be run on the SAMD51). Are you OK with merging this as-is, and we can create another PR to fit |
Yes -- absolutely -- go ahead -- pulseio may not fit anyway |
This freezes adafruit_bus_device and adafruit_rfm9x into the build for the feather_m0_rfm9x.
I had to take out several modules.
At this point, pulseio is removed. It may be possible to put it back once #3236 and #3237 are implemented. Right now some of the larger translations will not build with it and it does not work on the SAMD21 anyway. We can revisit this.
The main downside to removing it is we cannot support the DHT sensors.
I waned to get this out so it can be reviewed and be available for anyone to test.
adds Adafruit_CircuitPython_RFM9x to the frozen folder