-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Squeeze firmwares to fit the new ja translation #3273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently translated at 57.6% (446 of 773 strings) Translation: CircuitPython/main Translate-URL: https://hosted.weblate.org/projects/circuitpython/main/ja/
.. this disables SHARPMEMORY as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spending time on this. COUNTIO going away seems OK on the M0 boards. Hallowing M0 has largely been superseded by Hallowing M4, so that doesn't bother me terribly.
CIRCUITPY_BITBANGIO = 0 | ||
CIRCUITPY_COUNTIO = 0 | ||
CIRCUITPY_GAMEPAD = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AUDIOBUSIO is removed from (nearly?) all the other SAMD21 Express builds except for Metro M0. Could we be consistent about what's in generic M0 Express builds? Here instead GAMEPAD was removed, but you left I2CPERIPHERAL.
If we can be consistent, then these defaults could be moved to mpconfigport.h in the SAMD21 conditional section.
@@ -12,7 +12,9 @@ EXTERNAL_FLASH_DEVICES = "S25FL216K, GD25Q16C" | |||
|
|||
# Turn off features and optimizations for Crickit build to make room for additional frozen libs. | |||
LONGINT_IMPL = NONE | |||
CIRCUITPY_AUDIOBUSIO = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is AUDIOBUSIO useful for this CPX build? How does it compare with the other CPX builds, in terms of features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh -- yes it is -- PDMIn for the mic 🎤 . Might have to find something else to cut. I thought only in terms of I2SOut.
The ad-hoc-ness of this does point towards doing something more consistent. That said, I would like to get the "ja" translation in sooner rather than later... |
Dan notes that this is more frequently the solution we've chosen
AUDIOBUSIO is needed for the on-board mic using PDMIn
this now fits locally (though it's very close to capacity); let's see what the CI says. ``` make BOARD=metro_m0_express clean && make BOARD=metro_m0_express TRANSLATION=ja ... 253448 bytes used, 248 bytes free in flash firmware space out of 253696 bytes (247.75kB). ```
The stm boards default to `-O2`. Changing to `-Os` brings it back to ~43kB (!) free even for ja.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for continuing to work on this squeezing.
#3258 doesn't fit on these boards, so I trimmed them.
The most concerning change (to me) was disabling long int support on the hallowing_m0_express. If someone can provide a different alternative that passes the TRANSLATION=ja build I'm open to it.