STM32: Fix Meowbit startup and associated bugs #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jepler Mind reviewing this? |
jepler
approved these changes
Aug 27, 2020
Comment on lines
-242
to
247
| self->tim = NULL; | ||
|
|
||
| //if reserved timer has no active channels, we can disable it | ||
| if (!reserved_tim[self->tim->tim_index - 1]) { | ||
| tim_frequencies[self->tim->tim_index - 1] = 0x00; | ||
| stm_peripherals_timer_free(self->handle.Instance); | ||
| } |
There was a problem hiding this comment.
I am disappointed that gcc did not show a diagnostic for this. Amazing! glad you found it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR issues a number of bugfixes related to the Meowbit STM32F401 development board. These include:
common_hal_pulseio_pwmout_deinitwas causing a hardfault during release_displays. Fixed by moving things around and giving myself a nice hard facepalm.auto_brightnesswas set to true in the board_init setup of the Meowbit's TFT screen, which was disabling the screen backlight. This may have been changed behavior from the initial implementation, since this didn't seem to be a problem then. Fixed by setting auto_brightness to false.Regarding the LSE config problem, I considered adding a new safe mode category to contain issues with a board config, but quickly found that issues in the clock setup are so pervasive and confusing that any form of recovery or error management is probably misguided, especially for a theoretical audience of "board developers who mess up their clock settings and also don't have a debugger". As replacement, any issues in clock setup hang indefinitely in the config function for easy tracing with GDB.
Resolves #3314, and provides final wrap-up to #2702. Help testing would be greatly appreciated from anyone who has a Meowbit handy, I don't believe most of the usual core reviewers have them.