Add dirty rectangle tracking to Shape display element #3374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Sep 5, 2020
There was a problem hiding this comment.
I tested this on a CLUE and PyPortal using the code from the issue. This version does fix the problem on both devices with that code as it's written.
I noticed on the CLUE I could get back to non-refreshing state still by using lower values for the time.sleep(). I do think there is still something else going on there somehere.
The PyPortal seemed to handle it fine even at faster speeds that didn't work on the CLUE.
This is great extra functionality to be able to resize the Shape objects. Thanks for working on it @kmatch98 !
tannewt
requested changes
Sep 8, 2020
tannewt
requested changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue: #3201