atmel-samd: add same51, feather_m4_can #3384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is compile-tested, and requires updates in the related submodules: adafruit/samd-peripherals#35 adafruit/asf4#37 This should not be merged until those can also be merged.
|
@jepler are the asf4 and samd-peripheral submodules up to the versions you want in the PR now? |
|
No, I will tend to it tomorrow or monday. |
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Sep 12, 2020
.. there is an instance of it that looks like a "true positive", but it only affects sdhc transfers that are not a multiple of 4 bytes, which I don't think happens. (sd card blocks are always 512 bytes) I can fix this in our asf4 repo but that would mean this should be deferred until after adafruit#3384 is merged, since that also touches asf4 very invasively by adding a whole new chip family.
|
@dhalbert I think this is ready to go, both the related PRs are closed merged. |
dhalbert
requested changes
Sep 14, 2020
There was a problem hiding this comment.
Could you bump the submodule commits to the merge commits?
The merge commit for the latest asf4 is
adafruit/asf4@84f56af
Currently this is at https://github.com/adafruit/asf4/tree/1b87f18f8091f258e63f85cef54bcc7bafd44598
Similar for samd-peripherals: merge commit is adafruit/samd-peripherals@2ff4ab0.
This is at https://github.com/adafruit/samd-peripherals/tree/15fd96f4d8c38d5490767ea09469b82a231a768d
|
Happy to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is compile-tested, and requires updates in the related submodules:
adafruit/samd-peripherals#35
adafruit/asf4#37
This should not be merged until those can also be merged.