-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add non-DMA SPI support. #3393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-DMA SPI support. #3393
Conversation
This fixes SPI with PSRAM allocated buffers. DMA with SPI2 was attempted but produced junk output. This manual copy is less than 2x slower than DMA when not interrupted. Fixes micropython#3339
@emard please test artifacts from this build once it completes. Thanks! |
Currently I have tested this:
adafruit-circuitpython-espressif_saola_1_wroom-en_US-20200911-9256e6b.bin
everything works
adafruit-circuitpython-espressif_saola_1_wrover-en_US-20200911-9256e6b.bin
doesn't work
>> import spiloopback
loopback IO35-IO37
bytearray(b'\x00\x00\x00\x00') fail
bytearray(b'\x00\x00\x00\x00') fail
bytearray(b'\x00\x00\x00\x00') fail
bytearray(b'\x00\x00\x00\x00') fail
…On 9/11/20, Scott Shawcroft ***@***.***> wrote:
@emard please test artifacts from this build once it completes. Thanks!
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#3393 (comment)
|
Try a file from here: espressif_saola_1_wrover.zip The PR artifacts aren't available on S3. |
YEEESSS this one is fully working on WROVER and 2MB free!
I don't see any speed difference compared to WROOM.
However, if I use 64K buffer instead of 4K I get some
strange syntax error inside of the code where correct syntax is.
…On 9/11/20, Scott Shawcroft ***@***.***> wrote:
Try a file from here:
[espressif_saola_1_wrover.zip](https://github.com/adafruit/circuitpython/files/5211265/espressif_saola_1_wrover.zip)
The PR artifacts aren't available on S3.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#3393 (comment)
|
Strange syntax errors tend to happen when the host OS hasn't fully flushed it's writes to the filesystem. |
OK! |
Regarding latest SPI, Is SD card supposed to work on WROVER?
If I remove SD card then it prints: OSError: no SD card |
You are the first to try. Please file a separate issue. This might be default speed related or the MOSI state. |
@hierophect Please take a look. |
I don't see any issues with the Saleae. However, I'm unable to get my standard BMP_280 test working on this or the old pre-sram version, and it sounds like there may still be an issue with the SD card similar to the one on STM32-S2. I'll investigate those and make new issues if required. |
This fixes SPI with PSRAM allocated buffers. DMA with SPI2 was
attempted but produced junk output. This manual copy is less than
2x slower than DMA when not interrupted.
Fixes #3339