Skip to content

Issue #3367 Changed delay calls to avoid conflicts with qspi_disable #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 28, 2020
Merged

Issue #3367 Changed delay calls to avoid conflicts with qspi_disable #3453

merged 7 commits into from
Sep 28, 2020

Conversation

DavePutz
Copy link
Collaborator

Two calls to common_hal_delay_ms in common_hal_displayio_fourwire_reset() were changed to use common_hal_mcu_delay_us instead. This avoids a problem where qspi_disable was being called in the middle of the reset, which ended up disabling the SPI screen display on the Clue. This also fixes SPI TFT displays being used on other nrf52840 boards as well. It does not fix a similar issue with e-paper displays, which will need to be addressed separately.

@tannewt
Copy link
Member

tannewt commented Sep 23, 2020

Sorry, I understand this fixes the issue but I'd really like to understand the root cause.

The only way I imagine the reset failing is if the pulse is shorter than it should be. We should be able to verify that it is too short with a logic analyzer or oscilloscope. I'm worried the root cause is causing other issues.

@DavePutz
Copy link
Collaborator Author

Some info regarding power consumption with and without this PR. Data was gathered using an Adafruit INA260 power sensor running the peripherals script from @xiongyihui
6.0.0-alpha-3 (SPI not working)
1.026 mA 1.275 mW
6.0.0-alpha3 with nrf errata disabled (SPI working)
2.174 mA 6.619 mW
6.0.0-alpha-3 with this PR (SPI working)
1.075 mA 1.333 mW

@tannewt tannewt linked an issue Sep 28, 2020 that may be closed by this pull request
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DavePutz. The root cause search ended in an errata so this is the best fix. More info on the issue: #3367 (comment)

@tannewt tannewt merged commit ffeaef5 into adafruit:main Sep 28, 2020
@DavePutz DavePutz deleted the issue3367 branch December 30, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLUE display issues with 6.0.0-alpha3
3 participants