Skip to content

fix espressif latest idf #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2020
Merged

fix espressif latest idf #3519

merged 2 commits into from
Oct 8, 2020

Conversation

hathach
Copy link
Member

@hathach hathach commented Oct 7, 2020

[Not working yet]
I am trying to fix #3516 , I have fixed the build issue with hal file got move around with latest IDF. However, I got an linking issue. @hierophect Would you mind help me to fix this, then I will try to test out the usb patch.

xtensa-esp32s2-elf-gcc: error: esp-idf/components/xtensa/esp32s2/libhal.a: No such file or directory
xtensa-esp32s2-elf-gcc: error: esp-idf/components/xtensa/esp32s2/libhal.a: No such file or directory
make: *** [Makefile:319: build-espressif_saola_1_wrover/firmware.elf] Error 1

fix hal includes
@hathach hathach requested a review from hierophect October 7, 2020 17:56
@hierophect
Copy link
Collaborator

@hathach please use git to revert commit e01e8dd. I already did all the porting work to move the file names over, and this commit is where I moved them all back in order to support the older IDF version that worked well with TinyUSB. If you revert that commit, it should bring up everything back to a compile-able state.

@hathach hathach marked this pull request as ready for review October 8, 2020 06:30
@hathach
Copy link
Member Author

hathach commented Oct 8, 2020

@hathach please use git to revert commit e01e8dd. I already did all the porting work to move the file names over, and this commit is where I moved them all back in order to support the older IDF version that worked well with TinyUSB. If you revert that commit, it should bring up everything back to a compile-able state.

Ah thanks, I could get it build and fixed the usb configure with latest idf. And mark this PR as ready for review

Copy link
Collaborator

@hierophect hierophect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested on a Saola and it seems to be working just fine. Glad that all that time I spent chasing down those headers wasn't wasted - thanks for looking into this so quickly!

@hierophect hierophect merged commit 4bec776 into adafruit:main Oct 8, 2020
@hathach hathach deleted the fix-idf-latest branch October 8, 2020 16:25
@hathach
Copy link
Member Author

hathach commented Oct 8, 2020

I am glad that helps out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ESP-IDF to official version
2 participants