workflows: Replace deprecated ::set-env #3527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't right, because the place where I can spot the environment variable being used, it gives blank instead of the right value: |
jepler
force-pushed
the
issue3526-actions-setenv
branch
from
dd96422 to
3149f5b
Compare
|
Next iteration was right: However, the important "upload to s3" steps can't be 100% checked until after this is merged. |
hathach
reviewed
Oct 9, 2020
|
Build failure is a clone issue and unrelated. |
|
artifacts are uploading correctly after this was merged, and the warnings are gone from the overview page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3526