Skip to content

rgbmatrix: update protomatter to 1.0.5 tag #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

jepler
Copy link

@jepler jepler commented Oct 10, 2020

this is tested on

  • stm32f405 feather
  • matrixportal
  • nrf52840 feather
    which covers all of the supported microcontroller families.

this is compile-tested on
 stm32f405 feather
 matrixportal
 nrf52840 feather

but not actually tested-tested.
@FoamyGuy
Copy link
Collaborator

I built and tested this on Matrix Portal running the Monster eyes project everything is working well. I can test a few other devices as well.

Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on Feather M4 with the rainbow 2 line text scroller from here: https://learn.adafruit.com/rgb-led-matrices-matrix-panels-with-circuitpython/example-two-line-colorful-text-scroller and it's working well.

@jepler
Copy link
Author

jepler commented Oct 11, 2020

do you have an nrf52840 or stm32 you could test with? I expect all the m4 boards to function about the same, but testing these other too would be good. I'll set aside a bit of time on monday for it if you don't have the chance.

@FoamyGuy
Copy link
Collaborator

I'm trying to test out the 2 line text scroller linked above with Feather nrf52840 but having some trouble. I think it may be unrelated to this PR though. It seems the board pins are different. I'll see if I can get the correct pins worked out.

@FoamyGuy
Copy link
Collaborator

I tried to follow the pins from here: https://learn.adafruit.com/rgb-matrix-featherwing/pinouts#nrf52840-featherwing-wiring-3070338-12. My initializer looks like this:

matrix = rgbmatrix.RGBMatrix(
    width=64, height=32, bit_depth=4,
    rgb_pins=[board.D6, board.A5, board.A1, board.A0, board.A4, board.D11],
    addr_pins=[board.D10, board.D5, board.D13, board.D9],
    clock_pin=board.D12, latch_pin=board.RX, output_enable_pin=board.TX)

It's not throwing errors any more, but it's only showing a single blue row of pixels on one long edge of the screen. None of the scrolling text is drawing for me. I tried with this PR build as well as 5.3.1 and 6.0.0.beta2 and I am getting the same results on all of them.

@FoamyGuy
Copy link
Collaborator

I see now there is a separate feather wing needed for the nrf feathers, that is the source of my trouble.

I did also built this for stm32f405 and flashed a device with it. No issues that I noticed. But I'm not set up to run the matrix with that feather either.

@jepler
Copy link
Author

jepler commented Oct 12, 2020

Thanks for the testing you could do! I'll run this on some HW I do have, tomorrow.

@jepler
Copy link
Author

jepler commented Oct 12, 2020

I tested this on the STM32F405 Feather and the nRF52840 Feather. all work fine.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Clean up looks good.

@tannewt tannewt merged commit 1eb1434 into adafruit:main Oct 12, 2020
@jepler jepler deleted the update-protomatter-2 branch November 3, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants