Add socketpool.socket.recv_into size check #3563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To add the translation string in do I just manually edit the .pot file in the locale directory and weblate picks up the rest? Or is there a step I'm missing? |
Run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3421 Add error to socketpool.socket.recv_into when buffer is smaller than explicit size.
Added a check if the given buffer size is greater then the actual buffer given. Raises a ValueError if so.
I did (eventually) build this for an esp32s2 which seems to be the only port currently including it, but I do not have a chip to actually test it on.