-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ESP UART pins misnamed on some boards #3770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@brentru - please take a look at your convenience! |
Agreed! I'm ok with renaming the internally connected pins to
Which guides are effected by this change? |
This is the one I found so far: https://learn.adafruit.com/adafruit-pyportal/pinouts#step-3020486 |
May also need to update MiniESPTool examples (https://github.com/adafruit/Adafruit_CircuitPython_miniesptool/blob/master/examples/miniesptool_simpletest.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - uart removed, new ESP_
pins are correctly labelled for esp control.
This looks like it will not need revision because it will just pick up the new names, e.g.: tx = getattr(board, "ESP_TX", board.TX)
rx = getattr(board, "ESP_RX", board.RX) |
1 failure is an upload failure, unrelated to PR. |
I updated https://learn.adafruit.com/adafruit-pyportal/pinouts#step-3020486, which mentions the pin names, and also the sample AirLift BLE program here: https://learn.adafruit.com/adafruit-airlift-breakout/circuitpython-ble#copy-and-adjust-the-example-program-3076274-17. They mention that after CircuitPython 6.0.0, the pin names have changed. Once 6.1.0 is released for real, I can remove those caveats. |
I was helping someone with a PyPortal-using-BLE issue, and it turns out the ESP TX/RX pins on a few Airlift-style boards are labeled only
RX
andTX
, even though they are only connected to the ESP32. This makes them incompatible with theadafruit-airlift
library right now without giving different pin names.This PR adds
ESP_TX
andESP_RX
names to the existingTX
andRX
pins, which is upward compatible.However, I think that it would actually be better to remove the
TX
andRX
names and alsoboard.UART()
, since these are not externally available pins.If you agree, let me know and I'll revise this draft PR. One or two Guides would have to be updated as well.