Skip to content

Two minor socket changes #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2020
Merged

Two minor socket changes #3776

merged 1 commit into from
Dec 2, 2020

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Dec 1, 2020

  • Remove BrokenPipeError and prefer to return the number of bytes
    received. (May be zero.)
  • Add two minute backup timeout to reduce the chance we hang on
    recv accidentally.

@tannewt
Two minor socket changes
9276244 
* Remove BrokenPipeError and prefer to return the number of bytes
  received. (May be zero.)
* Add two minute backup timeout to reduce the chance we hang on
  recv accidentally.
@tannewt tannewt added bug espressif applies to multiple Espressif chips labels Dec 1, 2020
@tannewt tannewt added this to the 6.1.0 milestone Dec 1, 2020
@tannewt tannewt requested a review from jepler December 1, 2020 02:42
dhalbert
dhalbert approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These make sense to me.

@dhalbert dhalbert merged commit 9b3186b into adafruit:main Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees
No one assigned
Labels
bug espressif applies to multiple Espressif chips
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert