BLE fixes; magtag name fix #3848
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Characteristic and descriptor
max_length
s can be zero. Fixes BLE HID Keyboard not working in CircuitPython 6.0 #3746.Assure that
start_scan()
timeout is either zero or >= interval. This is a guess for this fix, but it coincides with working values reported in Low timeout values for BLERadio().start_scan() can lead to safe mode when calling BLERadio().connect() #3826. Fixes Low timeout values for BLERadio().start_scan() can lead to safe mode when calling BLERadio().connect() #3826.Assure that
start_scan()
max timeout is not too large for auint16_t
when passed to nRF SD. Fixes _bleio.Adapter.start_scan does not validate max timeout size #3340.Fixes small advertising interval values. Fix check and make sure it's at least 0.02001, to allow for rounding issues, as discussed in start_advertising interval does not accept the minimum 20ms value and may not range check correctly #2930. Fixes start_advertising interval does not accept the minimum 20ms value and may not range check correctly #2930.
Change MagTag board name to "Adafruit MagTag", so it appears in the support matrix in the right place. Fixes Change "MagTag" to "Adafruit MagTag" in the support matrix #3831.
Tested HID, and tested advertising scans with and without a timeout.