Skip to content

BLE fixes; magtag name fix #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Dec 18, 2020

Tested HID, and tested advertising scans with and without a timeout.

@dhalbert dhalbert requested review from tannewt and jepler December 18, 2020 22:38
@dhalbert
Copy link
Collaborator Author

The failing build is just a network problem.

dhalbert referenced this pull request in ElectronicCats/circuitpython Dec 20, 2020
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good to me! I think we should merge them into 6.0.x though so we can do a 6.0.1 release.

@dhalbert dhalbert mentioned this pull request Dec 22, 2020
@dhalbert
Copy link
Collaborator Author

BLE changes applied against 6.0.x instead in #3861. Closing this in favor of that PR. Will merge 6.0.x changes into main afterwards.

@dhalbert dhalbert closed this Dec 22, 2020
@dhalbert dhalbert deleted the ble-fixes branch December 22, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment