Add support for Winbond W25Q64FV #3855
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
reviewed
Dec 21, 2020
Comment on lines
38
to
40
|
|
||
| { MP_ROM_QSTR(MP_QSTR_SDA), MP_ROM_PTR(&pin_PB07) }, | ||
| { MP_ROM_QSTR(MP_QSTR_SCL), MP_ROM_PTR(&pin_PB06) }, |
There was a problem hiding this comment.
Did you mean to add these pins in this PR? There is no board.I2C() defined?
There was a problem hiding this comment.
- The SDA/SCL pins commit looks like it got added to the pull request after I'd created it when I added those to my fork - wasn't the intention that they be part of this pull
- Yes, tested W25Q64FV working with build of 6.1.0-beta.2 and head.
There was a problem hiding this comment.
could you push a new commit that removes the SDA and SCL pins?
This reverts commit 5d8b6c6.
|
Resubmitting with only W25Q64FV commit |
|
Clean pull request is fine, but not required. I'll use the other one, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.