FrequencyIn: do not raise in interrupt handler #3867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Darn it, I meant to PR this against 6.0.x. |
dhalbert
added a commit
that referenced
this pull request
Dec 23, 2020
Backport #3867 (FrequencyIn fix) to 6.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3788.
More info in #3788 (comment):
Remove this
mp_raise:circuitpython/ports/atmel-samd/common-hal/frequencyio/FrequencyIn.c
Line 85 in 8b03951
This is inside
frequencyin_emergency_cancel_capture(), which is called fromfrequencyin_interrupt_handler(). Interrupt handlers should not raise exceptions.Simply commenting out the
mp_raise_RuntimeError()prevents the crash. TheFrequencyInobject is still functional: I tested it with aPWMOut()running at 500Hz and got the expected value.This is a quick fix to remove the 6.0.0 regression and fatal error; #3788 did not occur in 5.3.1. A more complete solution can be worked out for later.
FrequencyInis still functional with this change.