Sleep API changes and fix for main.c silent issue #4503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
common_hal
prefix to a number of sleep-related functions to identify that they are implemented on the port level, and adds the new weakly linkedcommon_hal_alarm_pretending_deep_sleep
function, which is required for both the NRF and STM32 sleep implementations. It also fixes a small problem with the deep sleep implementation inmain.c
, where the 5 second USB delay would set up to useport_idle_until_interrupt
but never actually call it.Result of a discussion with @dhalbert. Contains the api breaking elements of both #4388 and #4236, ideally it should be merged before/immediately after either of them so all implementations of Alarm can be on the same page going forward.