Skip to content

[repl] Autocomplete builtin modules #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2021
Merged

[repl] Autocomplete builtin modules #4548

merged 3 commits into from
Apr 3, 2021

Conversation

tyomitch
Copy link

@tyomitch tyomitch commented Apr 3, 2021

mp_repl_autocomplete already had special handling to autocomplete the import statement; this PR makes it more useful by autocompleting modules to import.

The actual change is minor: 11 lines of new code; the rest is a refactoring of a massive, do-it-all, deeply nested function.

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Something I've often wished for. Didn't test.

@jepler jepler merged commit a9b42a0 into adafruit:main Apr 3, 2021
tyomitch added a commit to tyomitch/circuitpython that referenced this pull request Apr 30, 2021
tyomitch added a commit to tyomitch/circuitpython that referenced this pull request Apr 30, 2021
tyomitch added a commit to tyomitch/circuitpython that referenced this pull request Apr 30, 2021
Originally at adafruit#4548

Signed-off-by: Artyom Skrobov <[email protected]>
tyomitch added a commit to tyomitch/circuitpython that referenced this pull request May 1, 2021
Originally at adafruit#4548 and adafruit#4608

Signed-off-by: Artyom Skrobov <[email protected]>
dpgeorge pushed a commit to micropython/micropython that referenced this pull request May 2, 2021
dpgeorge pushed a commit to micropython/micropython that referenced this pull request May 2, 2021
dpgeorge pushed a commit to micropython/micropython that referenced this pull request May 2, 2021
Doing "import <tab>" will now complete/list built-in modules.

Originally at adafruit#4548 and adafruit#4608

Signed-off-by: Artyom Skrobov <[email protected]>
ksekimoto pushed a commit to ksekimoto/micropython that referenced this pull request Jul 16, 2021
ksekimoto pushed a commit to ksekimoto/micropython that referenced this pull request Jul 16, 2021
ksekimoto pushed a commit to ksekimoto/micropython that referenced this pull request Jul 16, 2021
Doing "import <tab>" will now complete/list built-in modules.

Originally at adafruit#4548 and adafruit#4608

Signed-off-by: Artyom Skrobov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants