esp32-s2: Don't set PWMOut frequency to 0 #4702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeatherS2 crashes if you set the PWMOut frequency to 0. This change will raise `ValueError: Invalid PWM frequency` if the requested frequency is 0. (Lifted from the atmel-samd port)
was causing pre-commit checks to fail
rsbohn12
reviewed
May 3, 2021
As MicroDev1 pointed out the problem is a divide by zero when calculating the duty cycle. Maybe need to check again in `common_hal_pwmio_pwmout_set_frequency()`.
microdev1
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FeatherS2 crashes if you set the PWMOut frequency to 0.
This change will raise
ValueError: Invalid PWM frequencyif the requested frequency is 0.(Lifted from the atmel-samd port)