Skip to content

Added New Board - Cytron Maker Pi RP2040 #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 30, 2021

Conversation

waiweng83
Copy link

Added the definition for Cytron Maker Pi RP2040.

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have one requested change for you to make.

@waiweng83
Copy link
Author

I'm wondering if there is a way to bundle a library together for this board?
For example I would like to include the neopixel.mpy together with the build.
Is this possible?

@ladyada
Copy link
Member

ladyada commented May 29, 2021

yes you can by 'freezing' a library - then it will be automatically included in the firmware
https://github.com/adafruit/circuitpython/blob/main/ports/atmel-samd/boards/adafruit_rotary_trinkey_m0/mpconfigboard.mk#L23

@waiweng83
Copy link
Author

yes you can by 'freezing' a library - then it will be automatically included in the firmware
https://github.com/adafruit/circuitpython/blob/main/ports/atmel-samd/boards/adafruit_rotary_trinkey_m0/mpconfigboard.mk#L23

Thanks. Should I submit another pull request or just modify this one?

@ladyada
Copy link
Member

ladyada commented May 29, 2021

keep modifying this one until its exactly how you want it!

@waiweng83
Copy link
Author

keep modifying this one until its exactly how you want it!

Alright. Will update here once it's done.

@waiweng83
Copy link
Author

yes you can by 'freezing' a library - then it will be automatically included in the firmware
https://github.com/adafruit/circuitpython/blob/main/ports/atmel-samd/boards/adafruit_rotary_trinkey_m0/mpconfigboard.mk#L23

How about the library which is not in the frozen library list?
I would like to include the SimpleIO as well.

We use that to generate tone for the buzzer.

@ladyada
Copy link
Member

ladyada commented May 29, 2021

you can add any library by using git submodule to add it :)

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks OK to me now. This can be merged once the automatic Checks have passed.

@waiweng83
Copy link
Author

Thank you. This looks OK to me now. This can be merged once the automatic Checks have passed.

Thanks a lot.

@waiweng83 waiweng83 requested a review from jepler May 30, 2021 02:57
@ladyada ladyada merged commit c80e253 into adafruit:main May 30, 2021
@waiweng83 waiweng83 deleted the add-maker-pi-rp2040 branch September 12, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants