RP2040 PWMAudioOut: Release DMA channels after play has finished #4958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RP2040
PWMAudioOut
stopping playing completely. It will stop playing after playing six samples."Scratchiness" and other audio quality issues are not necessarily addressed by this.
The essential problem was that the 12 DMA channels were being used up because the two that were being used were not freed after use, due to a missing
in
PWMAudioOut.c
.In the course of this I made some other more minor changes:
single_channel
tosingle_channel_output
to clarify its meaning. This changed a lot of files.PWMOut
, not inPWMAudioOut
.DMA_CH0_CTRL_TRIG_EN_BITS
andDMA_CH1_CTRL_TRIG_EN_BITS
. They are actually the same value, but it's possible in some future processor they might not be, so I regularized the use.