-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adding rainbow module. #4976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding rainbow module. #4976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick look, everything seems fine with me. One question but probably something you did on purpose.
The one failure is that some In Once #4903 is merged, we won't be so close to the edge on many builds. |
@dhalbert Fix submitted. Also updated copyright in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and congrats!
Partly addresses #4926. |
Sorry I just looked at this. We shouldn't call this We could call it |
|
So I really like |
We could make a |
Adds rainbow module with
colorwheel()
function. Removescolorwheel()
from_pixelbuf
.