Skip to content

Support multiple status neopixels #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2021
Merged

Support multiple status neopixels #5052

merged 2 commits into from
Jul 24, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jul 23, 2021

Use the 10 neopixels on the playgrounds for status.

Fixes #5039

@tannewt
Support multiple status neopixels
70cbb4e 
Use the 10 neopixels on the playgrounds for status.

Fixes micropython#5039
@tannewt tannewt added this to the 7.0.0 milestone Jul 23, 2021
@microdev1 microdev1 self-requested a review July 24, 2021 02:46
microdev1
microdev1 reviewed Jul 24, 2021
View reviewed changes
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Just one thing... issue #5051 seems like it is related to this.

ladyada
ladyada approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on both cpx and cpb (LEDs light up as expected)

@jepler jepler merged commit fa90635 into adafruit:main Jul 24, 2021
@jepler
Copy link

jepler commented Jul 24, 2021

Thanks! While there are other boards to apply this to (like the mentioned #5051, I thought of pygamer, etc) it becomes as easy as adding one line to a board's mpconfigboard.h so it's also simple to handle as separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microdev1 microdev1 microdev1 left review comments

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
atmel-samd enhancement nordic supervisor
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Blink 10 neopixels on playgrounds for status
4 participants
@tannewt @jepler @ladyada @microdev1