Skip to content

add board.LED wherever possible #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jul 27, 2021

Adds a board.LED to as many boards as possible. Sometimes this pin is also board.L, board.RED_LED, etc., but we're trying to make board.LED be as universal an experience as possible.

Adds a few other LED pins where they were found to be missing. (I looked at many schematics.)

Also adds whitespace on board files to make pin aliases more obvious.

Fixes #4939.

@dhalbert dhalbert requested a review from kattni July 27, 2021 00:02
Copy link

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

@kattni kattni merged commit 460643f into adafruit:main Jul 27, 2021
@dhalbert dhalbert deleted the led-everywhere branch July 28, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add board.LED to those boards that still need it
2 participants