Skip to content

Convert more modules to use MP_REGISTER_MODULE #5241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

capellini
Copy link

Convert bitbangio, bitmaptools, _bleio, board, busio, countio, digitalio, framebufferio, frequencyio, gamepadshift, getpass, keypad, math, microcontroller, and msgpack modules to use MP_REGISTER_MODULE.

Related to #5183.

Convert bitbangio, bitmaptools, _bleio, board, busio, countio, digitalio, framebufferio, frequencyio, gamepadshift, getpass, keypad, math, microcontroller, and msgpack modules to use MP_REGISTER_MODULE.

Related to adafruit#5183.
@capellini
Copy link
Author

capellini commented Aug 27, 2021

I also removed the duplicate code per #5183 (comment) and added the __name__ attribute to the bitmaptools module, per #5183 (comment).

I can also add the __name__ attribute to each of the ports for the board module, but that may take some time (unless there's a better way to add the __name__ attribute to the module).

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Didn't test, but looks good.

@jepler
Copy link

jepler commented Aug 27, 2021

I've split the board.__name__ off into its own issue so we can consider it separately.

@jepler jepler merged commit ab4ab2a into adafruit:main Aug 27, 2021
@capellini capellini deleted the mp-register-module-pybadge-b-m branch August 31, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants